markdown: make sure we don't ignore headers with trailing whitespace#23
Open
thaJeztah wants to merge 1 commit intodocker:mainfrom
Open
markdown: make sure we don't ignore headers with trailing whitespace#23thaJeztah wants to merge 1 commit intodocker:mainfrom
thaJeztah wants to merge 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
|
yeah we should add that case to the fixtures I think |
Member
Author
|
I'll try to have a look at that. I did give it a first quick try, but had trouble reading the diff 😂 |
Member
Author
|
Oooooh... actually, so is this the diff from "before" I removed the testify??? If so.. then testify's diff is not very readable either 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do we have a test for this already somewhere? (i.e. a test that combines markdown "examples" with the output generated from the command?)